Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 2 | Coursework#1217
Open
Seti-Jemal wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 2 | Coursework#1217Seti-Jemal wants to merge 6 commits intoCodeYourFuture:mainfrom
Seti-Jemal wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Seti-Jemal
added
Needs Review
cjyuan
reviewed
Mar 11, 2026
| // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase | ||
|
|
||
| function convertToUpperSnakeCase(str) { | ||
| return str.toUpperCase().trim().split("").join("_"); |
Contributor
There was a problem hiding this comment.
This works.
Could also consider using the string's methods .replaceAll() or replace().
cjyuan
added
Reviewed
Seti-Jemal
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Seti-Jemal
added
the
Needs Review
cjyuan
reviewed
Mar 14, 2026
Comment on lines
+8
to
+12
| const toPounds = (kg) => +(kg * 2.20462).toFixed(2); | ||
|
|
||
| const penceToPounds = (p) => `£${(p / 100).toFixed(2)}`; | ||
| const toUpperSnakeCase = (s) => s.toUpperCase().trim().split(" ").join("_"); | ||
| const multiply = (a, b) => a * b; |
Contributor
There was a problem hiding this comment.
-
Why implement 4 different functions in this file?
-
The input to the code in Sprint-1 is a "pence string" in the form "399p" (with a trailing 'p'). The function on line 10 would not work properly if the given
pis a string in this format. Can you update the function accordingly so that your function can return"£3.99"when the given argument is"399p"?
cjyuan
added
Reviewed
Seti-Jemal
added
Needs Review
cjyuan
reviewed
Mar 15, 2026
| // | ||
| // The penceToPounds function was updated to handle a pence string like "399p". | ||
| // It removes the "p", converts the value to a number, and divides by 100 | ||
| // so the function correctly returns "£3.99".s |
Contributor
There was a problem hiding this comment.
Have you tried calling penceToPounds("399p") to see if it can successfully return "£3.99"?
// Four functions are implemented because each one performs a specific task.
// This makes the code easier to read, reuse, and maintain.
However, three of the functions are not needed for converting pence string to pound string.
Perhaps you want to keep them in the file they belong to? Or keep them in separate file on your computer (if you want to save them for use later)?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed sprint 2